[ALICE3] IOTOF: Digitization for the TOF3 #15372
Merged
njacazio merged 26 commits intoAliceO2Group:devfrom May 8, 2026
Merged
Conversation
… from ALPIDE and probably nonsensical
iotof segmentation and parameters
…to retrieve chip index
Please consider the following formatting changes to AliceO2Group#15372
GiorgioAlbertoLucia
requested review from
fcolamar,
mconcas and
njacazio
as code owners
Collaborator
|
Error while checking build/O2/fullCI_slc9 for f30965d at 2026-05-07 13:28: Full log here. |
Updated return statement to remove false return value.
Updated detectorToLocalUnchecked methods to remove return type.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 2a32b97 at 2026-05-07 15:48: Full log here. |
njacazio
previously approved these changes
May 7, 2026
Removed the alias 'Mat3D' for 'o2::math_utils::Transform3D'.
njacazio
changed the title
njacazio
approved these changes
May 7, 2026
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 0dc1796 at 2026-05-07 21:28: Full log here. |
scannito
pushed a commit
to scannito/AliceO2
that referenced
this pull request
May 8, 2026
* one sensor per chip * one sensor per chip also in second layer * iotof segmentation and parameters. Segmentation parameters are stolen from ALPIDE and probably nonsensical * compute number of chips in IOTOF * fill L2G transformation matrices * fix cmakelist * only fill segmentation details if layout is segmented + add function to retrieve chip index * use proper chip id for segmented barrel * refactoring of segmentation, idependent for inner and outer tof, nonstatic * singleton implementation of the segmentation class * realistic values fot the chip segmentation * hit processing in place, tested on A3Studies/Digitization/testDigitization.cpp * clang format * protect against disks for now * added sanity checks * thickness that matches the values currently in O2 * default init of chipspecifics to zero * double typo (half the honor) * Please consider the following formatting changes * Fix row and column assignment in detector functions * Change return type in segmentation function Updated return statement to remove false return value. * Remove return statement from detectorToLocalUnchecked Updated detectorToLocalUnchecked methods to remove return type. * Remove Mat3D alias from GeometryTGeo class Removed the alias 'Mat3D' for 'o2::math_utils::Transform3D'. * Replace matrix transformation with Transform3D --------- Co-authored-by: maciacco <mario.ciacco@cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@njacazio
First steps towards a full digitization for TOF3